Conversation
|
@alexander-akait should we add flag to enable this behavior as dev server does? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3075 +/- ##
==========================================
- Coverage 91.50% 91.48% -0.03%
==========================================
Files 23 23
Lines 1719 1738 +19
Branches 519 524 +5
==========================================
+ Hits 1573 1590 +17
- Misses 146 148 +2
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Looks good, let's add couple tests - just create custom plugin with infinity waiting and send SIGINT signals to close it
|
/cc @alexander-akait |
|
@evenstensberg let's keep, it is a bug on our side |
|
Let's keep this open, because there is a bug on our side, we need fix it here - https://github.com/webpack/webpack-cli/blob/master/packages/webpack-cli/src/webpack-cli.ts#L2488 Easy fix |
|
I'll pick this up tomorrow. |
4 participants
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
WIP
If relevant, did you update the documentation?
Summary
Added code for graceful exit.
For reference: https://github.com/webpack/webpack-dev-server/blob/75999bb9bb8803de633fcb037405f45a5bf7d029/lib/Server.js#L1808-L1838
Does this PR introduce a breaking change?
Yup can be for tools that consume webpack-cli's output.
Other information
/cc @alexander-akait